fix(sqlite): Removed ToLower in typecast#3860
Open
giuliano-macedo wants to merge 3 commits intosqlc-dev:mainfrom
Open
fix(sqlite): Removed ToLower in typecast#3860giuliano-macedo wants to merge 3 commits intosqlc-dev:mainfrom
giuliano-macedo wants to merge 3 commits intosqlc-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3688 by not calling
NewIdentifier(name)inconvertCastExprbecause this function was ending up callingstrings.ToLoweron the type name resulting in type overrides not matching because the cast type name was always lowerCase and the override was always uppercase ingo_type.go@goInnerType.Alternatively this issue could by changing this line in
goInnerType:to
But I don't know if this would be a good idea...
Since we're already here, I've added tests for this specific case of type casts + overrides in sqlite, and refacted a variable in
convertCastExprbecausenamecould be confused with the column name instead of type name.